Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reference functions directly #5277

Merged
merged 1 commit into from
Feb 18, 2023
Merged

test: reference functions directly #5277

merged 1 commit into from
Feb 18, 2023

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Feb 18, 2023

What's the problem this PR addresses?

Some of our test code is referencing methods in the same file through exports which works due to how Babel transpiles the files, however when transpiled by esbuild it throws.

TypeScript doesn't complain because @types/node contains declare var exports: any.

How did you fix it?

Reference the functions directly.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 9b3f92b into master Feb 18, 2023
@arcanis arcanis deleted the merceyz/test/exports branch February 18, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants