feat: Tolerate string literals w/ ppath.join
/ ppath.resolve
#5250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
It's currently a little annoying to work with the fslib in tests, because all literal paths have to explicitly convert paths into
PortablePath
orFilename
when passing them toppath.join
orppath.resolve
- even if they are literal strings, which are highly unlikely to be non-portable.How did you fix it?
New generic overrides for
ppath.join
andppath.resolve
now tolerate string literals as arguments.This is only true for those two methods; I didn't find a reasonable way to achieve it for all the FakeFS methods without all implementations having to copy / paste the signature.
Checklist