fix(ZipFS): support empty archives resulting from an unlink after write in getBufferAndClose
#5179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te in `getBufferAndClose`
3 tasks
merceyz
pushed a commit
that referenced
this pull request
Jan 29, 2023
…te in `getBufferAndClose` (#5179) * fix(ZipFS): support empty archives resulting from an unlink after write in `getBufferAndClose` * chore: update artifacts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
ZipFS.getBufferAndCloseerrors on an empty archive resulting from an unlink after write.I forgot to add a test for this case in #3241.
Fixes https://github.com/yarnpkg/berry/actions/runs/3852391756/jobs/6564499446#step:6:9.
How did you fix it?
Added an early check that discards the archive and returns an empty archive buffer.
Checklist