fix(core): handle self-referencing build dependencies #5177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
paul-soporan
reviewed
Jan 8, 2023
| @@ -1351,7 +1351,7 @@ export class Project { | |||
|
|
|||
| const workspace = this.tryWorkspaceByLocator(dependencyPkg); | |||
| if (workspace) { | |||
| if (buildablePackages.has(workspace.anchoredLocator.locatorHash)) | |||
| if (resolution !== workspace.anchoredLocator.locatorHash && buildablePackages.has(workspace.anchoredLocator.locatorHash)) | |||
There was a problem hiding this comment.
Perhaps I'm too tired and reading this incorrectly, but isn't this checking whether the transitive workspace dependency is different from the devirtualized workspace?
Shouldn't it be?
Suggested change
| if (resolution !== workspace.anchoredLocator.locatorHash && buildablePackages.has(workspace.anchoredLocator.locatorHash)) | |
| if (resolution !== locator.locatorHash && buildablePackages.has(workspace.anchoredLocator.locatorHash)) |
There was a problem hiding this comment.
You're reading it correctly, that's a mistake on my part however your suggested change isn't correct either, the check was supposed to check that the devirtualized workspace wasn't the original locator. I changed it to workspace.anchoredLocator.locatorHash !== locator.locatorHash and added a new test.
packages/acceptance-tests/pkg-tests-specs/sources/commands/install.test.js
Outdated
Show resolved
Hide resolved
2 tasks
merceyz
added a commit
that referenced
this pull request
Jan 29, 2023
* fix(core): handle self-referencing build dependencies * chore: revert e2e trigger * fix(core): handle self-referencing virtual workspace build dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
#5162 didn't handle self-referencing build dependencies.
Fixes https://github.com/yarnpkg/berry/actions/runs/3848381377/jobs/6556091151#step:4:65 and https://github.com/yarnpkg/berry/actions/runs/3848381374/jobs/6556092179#step:4:52
How did you fix it?
Handle self-referencing build dependencies.
Checklist