Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): update patch for [email protected] #5127

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Dec 8, 2022

What's the problem this PR addresses?

The PnP compatibility patch for TypeScript doesn't apply to [email protected].

Fixes #5125

How did you fix it?

Rebased microsoft/TypeScript#35206 onto the 4.9.4 release.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@RDIL
Copy link
Member

RDIL commented Dec 8, 2022

Something's not right with the CI... no clue what.

@merceyz
Copy link
Member Author

merceyz commented Dec 8, 2022

ubuntu-latest is now 22.04 which uses OpenSSL v3 which pem doesn't support.
https://github.blog/changelog/2022-11-09-github-actions-ubuntu-latest-workflows-will-use-ubuntu-22-04/
Dexus/pem#316

@merceyz merceyz merged commit e3c761a into master Dec 9, 2022
@merceyz merceyz deleted the merceyz/fix/typescript-494 branch December 9, 2022 16:37
@espoal
Copy link

espoal commented Dec 11, 2022

@merceyz for me it's still not working. I set the latest version of yarn with yarn set version canary, with ts ^4.9.4

what could I be doing wrong?

@RDIL
Copy link
Member

RDIL commented Dec 11, 2022

No new canary has been created since the PR was merged. I just triggered a canary build, so it should be available within an hour or so.

kris7t added a commit to graphs4value/refinery that referenced this pull request Jan 28, 2023
Support for [email protected] available in yarn 4.0.0-rc.33 according to
yarnpkg/berry#5127 (comment)

Also updates other frontend dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: TS 4.9.4 PnP Cannot find module error
3 participants