Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-nm): Changes the default nmMode back to classic #5099

Merged
merged 5 commits into from
Nov 30, 2022

Conversation

larixer
Copy link
Member

@larixer larixer commented Nov 26, 2022

What's the problem this PR addresses?

During testing caching of node_modules created with hardlinks-local install mode on GitHub Actions, I have noticed that on Windows platform there are issues with storing and restoring hardlinks via tar, which is used by actions/cache.

Reverts #4504

How did you fix it?

Changed the default nmMode back to classic to avoid issues with GitHub Actions caching on Windows.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the changelog to remove

- Set `nmMode` to `hardlinks-local` by default.
as well?
Should https://github.com/yarnpkg/berry/pull/4504/files#diff-b6f2618cc58bd274cb6c2114799ab4f80cd5971a299ea847dd8c031c5c411134 be reverted as well?

@larixer
Copy link
Member Author

larixer commented Nov 26, 2022

Could you update the changelog to remove

- Set `nmMode` to `hardlinks-local` by default.

as well?
Should https://github.com/yarnpkg/berry/pull/4504/files#diff-b6f2618cc58bd274cb6c2114799ab4f80cd5971a299ea847dd8c031c5c411134 be reverted as well?

Yes, good catch, thank you, will do!

@merceyz merceyz enabled auto-merge (squash) November 30, 2022 01:01
@merceyz merceyz merged commit f840b8a into master Nov 30, 2022
@merceyz merceyz deleted the larixer/nm-mode-default-back-to-classic branch November 30, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants