test(shell): fix failing tests #4969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
approved these changes
Oct 18, 2022
merceyz
pushed a commit
that referenced
this pull request
Oct 22, 2023
Update shell.test.ts (cherry picked from commit 1379b71)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
We were running some test by calling missing binaries to check for the
||and&&operators. While it worked, it seems that on Windows some extra cruft is printed on stderr, tainting the expectations.How did you fix it?
Instead of calling a non-existent binary, we now just call the
falsebuiltin (which has the same effect but doesn't output anything).Checklist