Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the install section of all plugin's readme #4948

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

jj811208
Copy link
Contributor

@jj811208 jj811208 commented Oct 8, 2022

What's the problem this PR addresses?

Since #4253, users no longer need to manually install the official plugins, so the readme installation section is outdated
...

How did you fix it?

Change the install section of all plugin's readme to This plugin is included by default in Yarn 4.
...

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@jj811208 jj811208 force-pushed the docs/plugin-readme branch from e937c08 to ba44aeb Compare October 8, 2022 19:15
paul-soporan
paul-soporan previously approved these changes Oct 8, 2022
Copy link
Member

@paul-soporan paul-soporan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Nit: in could probably be changed to starting from to be more future proof.

… plugin is included by default in Yarn4.`
@jj811208
Copy link
Contributor Author

jj811208 commented Oct 9, 2022

Nit: in could probably be changed to starting from to be more future proof.

That sounds good~

I modified it

Copy link
Member

@paul-soporan paul-soporan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@paul-soporan paul-soporan merged commit 54907c5 into yarnpkg:master Oct 9, 2022
@jj811208 jj811208 deleted the docs/plugin-readme branch October 13, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants