docs: mention zero-installs repo size #4839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
changed the title
trivikr
reviewed
Sep 13, 2022
|
|
||
| ### What does this do to my repository size? | ||
|
|
||
| Every time you update a dependency and commit this, the repository will grow. |
There was a problem hiding this comment.
likely grow?
Suggested change
| Every time you update a dependency and commit this, the repository will grow. | |
| Every time you update a dependency and commit this, the repository will likely grow. |
Although not common, some popular projects do prioritize reducing install sizes.
There was a problem hiding this comment.
Even if the install size is smaller, the repo itself will grow, as the previous version will be part of the history. So it will always grow, as far as I understand.
There was a problem hiding this comment.
But that does mean that I should clarify this a bit more.
There was a problem hiding this comment.
I've added some clarification in the sentence
|
I've updated the section to include more information around possible mitigations. |
RDIL
approved these changes
Sep 13, 2022
RDIL
added
the
documentation
merceyz
approved these changes
Sep 13, 2022
merceyz
pushed a commit
that referenced
this pull request
Sep 15, 2022
* #180 mention zero-installs repo size concern * Update zero-installs.md * Update zero-installs.md Co-authored-by: Maël Nison <[email protected]>
merceyz
pushed a commit
that referenced
this pull request
Sep 21, 2022
* #180 mention zero-installs repo size concern * Update zero-installs.md * Update zero-installs.md Co-authored-by: Maël Nison <[email protected]>
merceyz
pushed a commit
that referenced
this pull request
Oct 5, 2022
* #180 mention zero-installs repo size concern * Update zero-installs.md * Update zero-installs.md Co-authored-by: Maël Nison <[email protected]>
merceyz
pushed a commit
that referenced
this pull request
Oct 29, 2022
* #180 mention zero-installs repo size concern * Update zero-installs.md * Update zero-installs.md Co-authored-by: Maël Nison <[email protected]>
merceyz
pushed a commit
that referenced
this pull request
Nov 16, 2022
* #180 mention zero-installs repo size concern * Update zero-installs.md * Update zero-installs.md Co-authored-by: Maël Nison <[email protected]>
merceyz
pushed a commit
that referenced
this pull request
Dec 20, 2022
* #180 mention zero-installs repo size concern * Update zero-installs.md * Update zero-installs.md Co-authored-by: Maël Nison <[email protected]>
merceyz
pushed a commit
that referenced
this pull request
Feb 1, 2023
* #180 mention zero-installs repo size concern * Update zero-installs.md * Update zero-installs.md Co-authored-by: Maël Nison <[email protected]>
merceyz
pushed a commit
that referenced
this pull request
Mar 16, 2023
* #180 mention zero-installs repo size concern * Update zero-installs.md * Update zero-installs.md Co-authored-by: Maël Nison <[email protected]>
merceyz
pushed a commit
that referenced
this pull request
May 1, 2023
* #180 mention zero-installs repo size concern * Update zero-installs.md * Update zero-installs.md Co-authored-by: Maël Nison <[email protected]>
merceyz
pushed a commit
that referenced
this pull request
Jun 1, 2023
* #180 mention zero-installs repo size concern * Update zero-installs.md * Update zero-installs.md Co-authored-by: Maël Nison <[email protected]>
merceyz
pushed a commit
that referenced
this pull request
Oct 21, 2023
* #180 mention zero-installs repo size concern * Update zero-installs.md * Update zero-installs.md Co-authored-by: Maël Nison <[email protected]> (cherry picked from commit 5d55fc6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Some have concerns about repository size using zero-installs. This could be addressed in the feature page. It might also help some users who are unaware of this potential downside to make a better decision on whether this is good for them.
See #180
How did you fix it?
Mention it in the
concernssection of the feature page.Checklist