Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fslib): add fchown support #4801

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Conversation

jj811208
Copy link
Contributor

@jj811208 jj811208 commented Aug 28, 2022

What's the problem this PR addresses?

The yarn filesystems doesn't support fchown.

How did you fix it?

Implemented support for it in the various filesystems.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@jj811208 jj811208 force-pushed the feat/fchown branch 2 times, most recently from c814aa9 to fe7e7f4 Compare August 28, 2022 07:20
@jj811208
Copy link
Contributor Author

I'm trying to add fchown function to the fslib module, but my new test doesn't work on ci runner, the chown command seems to require higher privileges, but ci runner is just a normal user. (a related discussion: https://github.com/orgs/community/discussions/26717

I'm not quite sure how to solve this problem, can anyone help me?

@jj811208 jj811208 marked this pull request as ready for review August 28, 2022 08:05
@jj811208 jj811208 requested a review from arcanis as a code owner August 28, 2022 08:05
@arcanis
Copy link
Member

arcanis commented Sep 3, 2022

I'd go with dropping the test in this instance, since they are difficult to implement in a portable way. Alternatively we could check whether the chown fails with the right error message, but it might not work everywhere either 😕

@jj811208
Copy link
Contributor Author

jj811208 commented Sep 5, 2022

I'd go with dropping the test in this instance, since they are difficult to implement in a portable way. Alternatively we could check whether the chown fails with the right error message, but it might not work everywhere either 😕

Thanks for the reply.

Ok, I deleted the test and rebase the branch onto master.

@arcanis arcanis merged commit 76ccb18 into yarnpkg:master Sep 5, 2022
@arcanis
Copy link
Member

arcanis commented Sep 5, 2022

Perfect, thanks a lot!

merceyz pushed a commit that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants