Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove pnpDataPath #4773

Merged
merged 3 commits into from
Aug 18, 2022
Merged

refactor!: remove pnpDataPath #4773

merged 3 commits into from
Aug 18, 2022

Conversation

paul-soporan
Copy link
Member

What's the problem this PR addresses?

pnpDataPath is the only PnP file whose location can be customized, which means that:

  • it's tied to the Yarn configuration
  • it doesn't adhere to our new specification
  • it makes it impossible for third-party tools implementing the PnP specification to use it without reading the Yarn configuration which doesn't make sense

How did you fix it?

Removed it.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@paul-soporan paul-soporan mentioned this pull request Aug 17, 2022
Closed
13 tasks
@arcanis arcanis merged commit 8963fc0 into master Aug 18, 2022
@arcanis arcanis deleted the paul/refactor/remove-pnpDataPath branch August 18, 2022 16:19
@jonaskuske jonaskuske mentioned this pull request Oct 24, 2022
Closed
@merceyz merceyz added this to the 4.0.0 milestone May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paul-soporan @arcanis @merceyz