fix(fs): Fixes the Zip magic fd bits #4737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
requested changes
Aug 11, 2022
merceyz
requested changes
Aug 12, 2022
merceyz
approved these changes
Aug 12, 2022
This was referenced Aug 12, 2022
merceyz
pushed a commit
that referenced
this pull request
Aug 19, 2022
* Fixes the Zip magic fd bits * Reverts changes to the readdir signatures * Reverts extra changes * Updates the hook * Feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
We currently use 0x80000000 as magic bits to detect whether a file descriptor is owned by the ZipOpenFS layer or not. This causes all such file descriptors to become invalid, because they overflow into negative integers.
Ref evanw/esbuild#2458 (still not fixed, because of the other problem described in evanw/esbuild#2458 (comment))
How did you fix it?
Changes the magic bits into 0x2a000000.
Checklist