fix(core): support migrating resolutions from JFrog Artifactory registries regardless of the domain #4702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sargunv
changed the title
merceyz
changed the title
|
Thanks for merging! |
merceyz
added a commit
that referenced
this pull request
Aug 19, 2022
…tries regardless of the domain (#4702) * artifactory * release workflow * PR url comment * chore: unmark `plugin-essentials` for release Co-authored-by: merceyz <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
It's common for companies to host their packages at an Artifactory deployment on their own domain, like
packages.mycompany.com. This has the same URL pattern as any other JFrog repository, but on a non-JFrog domain.Currently, migrating a Yarn v1 project that uses such packages fails due to the package URLs in the lockfile not being recognized, blocking easy migration at my company.
Example URL:
We currently work around this with
sed -i 's|/-/@convoy/|/-/|' yarn.lockto essentially fake the standard URL format right before migration....
How did you fix it?
Update the regex for the JFrog URL format to allow arbitrary domain names.
Updated the relevant test case with such a URL.
...
Checklist
(I think I set this correctly, reviewers please verify. I'm not 100% sure if any other packages need to be released vs declined)