fix(plugin-pnpm) Pnpm linker avoids symlink loops on the file system #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
e-im
added a commit
to PaperMC/docs
that referenced
this pull request
Jun 26, 2022
Manually merge yarnpkg/berry#4542 to fix issue with the dev server.
merceyz
approved these changes
Jul 15, 2022
github-actions
bot
removed
the
infra: pending update
merceyz
previously approved these changes
Jul 15, 2022
merceyz
force-pushed
the
larixer/pnpm-symlink-loops
branch
from
2f430a4 to
9febb09
Compare
|
Downside to having the bot update the branch, the CI wont run. |
merceyz
approved these changes
Jul 15, 2022
jakutis
pushed a commit
to jakutis/berry
that referenced
this pull request
Aug 11, 2022
…arnpkg#4542) * Pnpm linker avoids symlink loops on the file system * symlinkDst -> symlinkDstPath for uniformity with nearby code * Avoids self-require trap * Store paths rather than linkType, and remove now-irrelevant cleanup code * Adds test * Don't create self-references for workspaces, to avoid infinite loops Co-authored-by: Maël Nison <[email protected]>
7 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Fixes #4525
How did you fix it?
Symlinks for dependencies are created higher in the directory structure. Instead of
<project_root>/node_modules/.store/webpack-cli-virtual-66f7aceb77/node_modules/webpack-cli/node_modules/commander,the symlink is created at:
<project_root>/node_modules/.store/webpack-cli-virtual-66f7aceb77/node_modules/commanderThis is the same way as
pnpmdoes. This avoids the symlink loop on the file system. It works, because Node.js fallbacks torealpathand parent directories look up when it fails to find a module without applyingrealpath.Checklist