Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes yarn version apply #4336

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Fixes yarn version apply #4336

merged 2 commits into from
Apr 7, 2022

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Apr 7, 2022

What's the problem this PR addresses?

We don't use yarn version apply much, and when trying to use it to bump the ZipFS extension I noticed it caused all release markers to be dropped (instead of just the ones relative to the package being bumped).

How did you fix it?

Fixed to only remove the entries relative to the packages being bumped.

A followup will be to write tests, but I want to make the release before that 🙂

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 5ae7b8a into master Apr 7, 2022
@arcanis arcanis deleted the mael/version-apply-fix branch April 7, 2022 21:59
merceyz pushed a commit that referenced this pull request Oct 22, 2023
* Fixes version apply

* Versions

(cherry picked from commit 5ae7b8a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants