perf(pnp): hoist data string #4320
Merged
+45,442
−45,405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
#3977 improved the startup time of the PnP hook but we can do more.
How did you fix it?
Hoist the data string to the top level to avoid V8 parsing it multiple times. https://v8.dev/blog/preparser
Benchmark results
Gatsby benchmark:
Next.js repo:
Checklist