Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: informations => information #4082

Merged
merged 7 commits into from
Mar 8, 2022

Conversation

francisu
Copy link
Contributor

@francisu francisu commented Feb 8, 2022

What's the problem this PR addresses?

Fix a non-English word

Did not make an issue for this.
...

How did you fix it?

Change informations => information
...

Checklist

  • I have set the packages that need to be released for my changes to be effective.
    (installing the yarn version plugin failed)
  • I will check that all automated PR checks pass before the PR gets reviewed.

@francisu
Copy link
Contributor Author

francisu commented Feb 8, 2022

Not sure what to do about the failing windows test, does not seem to be related to the PR. Is there a way it can be rerun?

Comment on lines +1 to +4
releases:
"@yarnpkg/cli": patch
"@yarnpkg/core": patch
"@yarnpkg/pnp": patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yarnpkg/plugin-pnp needs a release too since the hook got updated. Also, I don't get why the core needs one 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because otherwise the cli wouldn't be suggested, since it doesn't directly depend on yarnpkg/pnp. Although I guess plugin-pnp would have worked as well.

@paul-soporan
Copy link
Member

Not sure what to do about the failing windows test, does not seem to be related to the PR. Is there a way it can be rerun?

It's a flaky test unrelated to this PR, no need to worry about it. Only team members can rerun it but there isn't really a point to do it since we'll be waiting for @arcanis to merge it anyways (he can bypass failing checks).

@arcanis arcanis added infra: pending update A bot will merge master into this PR and removed infra: pending update A bot will merge master into this PR labels Mar 3, 2022
@github-actions github-actions bot removed the infra: pending update A bot will merge master into this PR label Mar 7, 2022
@arcanis arcanis added the infra: pending update A bot will merge master into this PR label Mar 7, 2022
@github-actions github-actions bot removed the infra: pending update A bot will merge master into this PR label Mar 7, 2022
@arcanis arcanis added the infra: pending update A bot will merge master into this PR label Mar 7, 2022
@github-actions github-actions bot removed the infra: pending update A bot will merge master into this PR label Mar 7, 2022
@arcanis arcanis added the infra: pending update A bot will merge master into this PR label Mar 7, 2022
@github-actions github-actions bot removed the infra: pending update A bot will merge master into this PR label Mar 7, 2022
@arcanis arcanis merged commit 3edfba5 into yarnpkg:master Mar 8, 2022
merceyz pushed a commit that referenced this pull request Oct 21, 2023
* chore: informations => information

* chore: informations => information

* Updates hook

* Versions

Co-authored-by: Maël Nison <[email protected]>
Co-authored-by: Yarn Bot <[email protected]>
(cherry picked from commit 3edfba5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants