Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors how the publish registry is computed #233

Merged
merged 11 commits into from
Jun 14, 2019

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Jun 14, 2019

This diff:

  • Updates the documentation to properly reference the split between npmScopes and npmRegistries
  • Updates yarn npm login to properly store the registry credentials inside npmRegistries
  • Makes yarn npm login and yarn npm whoami compatible with the publish registry

In concrete terms, the main difference is that the npmConfigUtils module now exports tools to let the caller of npmHttpUtils have slightly more control on which registry is meant to be used for a specific query. This is optional, and passing an Ident instead of a registry will go into the typical workflow.

@deini
Copy link
Member

deini commented Jun 14, 2019

Do we need to update the npmScopes type then to not have the authToken?

@arcanis
Copy link
Member Author

arcanis commented Jun 14, 2019

Yep, that sounds the right thing to do 👍

@arcanis arcanis merged commit 3c230fd into master Jun 14, 2019
@arcanis arcanis deleted the publish-registry-refactoring branch June 14, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants