-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug?]: The default compression level is not 'mixed' #5843
Labels
bug
Something isn't working
Comments
This does not appear to be a bug, and the documentation needs to be updated. The default compressionLevel was explicitly set to |
3 tasks
arcanis
added a commit
that referenced
this issue
Oct 24, 2023
**What's the problem this PR addresses?** Closes: #5843 Refs: #5526 **How did you fix it?** Updated the default compressionLevel to '0' in documentation. **Checklist** <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [x] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed. --------- Co-authored-by: Maël Nison <[email protected]>
3 tasks
arcanis
pushed a commit
that referenced
this issue
Oct 24, 2023
) **What's the problem this PR addresses?** Refs: #5843 **How did you fix it?** Moves compressionLevel `mixed` enum value to the end as: * `mixed` is no longer the default in [email protected] * `mixed` is a variant of 9. Visually keeping it closer to 9 is more intuitive. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Self-service
Describe the bug
As per the documentation, the default value for compressionLevel is
mixed
.But my testing shows that it's
0
by default in4.0.0
.It was
mixed
in yarn3.6.4
.Is this a breaking change in [email protected]?
To reproduce
Environment
System: OS: macOS 14.0 CPU: (8) arm64 Apple M1 Pro Binaries: Node: 18.18.0 - /private/var/folders/42/54jl1_3x4hz06cf7bc_kzd4h0000gn/T/xfs-bf3e2b66/node Yarn: 4.0.0 - /private/var/folders/42/54jl1_3x4hz06cf7bc_kzd4h0000gn/T/xfs-bf3e2b66/yarn npm: 9.8.1 - ~/Library/Caches/fnm_multishells/36083_1698158145925/bin/npm
Additional context
No response
The text was updated successfully, but these errors were encountered: