Skip to content

Commit

Permalink
Removes Node 10 from the matrix (#2373)
Browse files Browse the repository at this point in the history
* Removes Node 10 from the matrix

* Versions

* Fixes Node for Angular

* Another missing version change
  • Loading branch information
arcanis authored Jan 13, 2021
1 parent cfec63a commit 552a31c
Show file tree
Hide file tree
Showing 26 changed files with 70 additions and 50 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/e2e-cra-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-eslint-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-fsevents-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-gatsby-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-husky-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-jest-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-mocha-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-next-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-nm-angular-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ jobs:

- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-nm-babel-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ jobs:

- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-nm-berry-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-nyc-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-pnpify-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-prettier-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-rollup-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-snowpack-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-storybook-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-typescript-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-vue-cli-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/e2e-webpack-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand All @@ -38,11 +38,11 @@ jobs:
mkdir src
echo "import _ from 'lodash';function printHello() { console.log(_.join(['Hello', 'webpack'], ' '))}; printHello();" | tee src/index.js
yarn webpack info
yarn webpack
[[ "$(node dist/main.js)" = "Hello webpack" ]]
- name: 'raw-loader'
run: |
source scripts/e2e-setup-ci.sh
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/integration-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@ jobs:
fail-fast: false
matrix:
node:
- 10
- 12
- 14
- 15
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/plugin-compat-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Build the standard bundle'
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sherlock-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ jobs:
steps:
- uses: actions/checkout@master

- name: 'Use Node.js 10.x'
- name: 'Install Node'
uses: actions/setup-node@master
with:
node-version: 10.x
node-version: 14.x

- name: 'Always use the latest sherlock'
run: |
Expand Down
22 changes: 22 additions & 0 deletions .yarn/versions/20cff2cf.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
releases:
"@yarnpkg/cli": major

declined:
- "@yarnpkg/plugin-compat"
- "@yarnpkg/plugin-constraints"
- "@yarnpkg/plugin-dlx"
- "@yarnpkg/plugin-essentials"
- "@yarnpkg/plugin-init"
- "@yarnpkg/plugin-interactive-tools"
- "@yarnpkg/plugin-node-modules"
- "@yarnpkg/plugin-npm-cli"
- "@yarnpkg/plugin-pack"
- "@yarnpkg/plugin-patch"
- "@yarnpkg/plugin-pnp"
- "@yarnpkg/plugin-stage"
- "@yarnpkg/plugin-typescript"
- "@yarnpkg/plugin-version"
- "@yarnpkg/plugin-workspace-tools"
- "@yarnpkg/builder"
- "@yarnpkg/core"
- "@yarnpkg/doctor"
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

### **Breaking Changes**

- Node 10 isn't supported anymore.
- The `initVersion` and `initLicense` configuration options have been removed. `initFields` should be used instead.
- Yarn will now generate `.pnp.cjs` files (instead of `.pnp.js`) when using PnP, regardless of what the `type` field inside the manifest is set to.
- The `-a` alias flag of `yarn workspaces foreach` got removed; use `-A,--all` instead, which is strictly the same.
Expand Down
4 changes: 1 addition & 3 deletions packages/yarnpkg-cli/sources/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,11 @@ export async function main({binaryVersion, pluginConfiguration}: {binaryVersion:

async function exec(cli: Cli<CommandContext>): Promise<void> {
// Non-exhaustive known requirements:
// - 10.16+ for Brotli support on `plugin-compat`
// - 10.17+ to silence `got` warning on `dns.promises`
// - 14.0 and 14.1 empty http responses - https://github.com/sindresorhus/got/issues/1496
// - 14.10.0 broken streams - https://github.com/nodejs/node/pull/34035 (fix: https://github.com/nodejs/node/commit/0f94c6b4e4)

const version = process.versions.node;
const range = `>=10.17 <14 || 14.2 - 14.9 || >14.10.0`;
const range = `>=12 <14 || 14.2 - 14.9 || >14.10.0`;

if (process.env.YARN_IGNORE_NODE !== `1` && !semverUtils.satisfiesWithPrereleases(version, range))
throw new UsageError(`This tool requires a Node version compatible with ${range} (got ${version}). Upgrade Node, or set \`YARN_IGNORE_NODE=1\` in your environment.`);
Expand Down

0 comments on commit 552a31c

Please sign in to comment.