chore: add lint rule for semver.validRange and semver.Range (#4407)

(cherry picked from commit 0eb915f)
yarnpkg · Nov 21, 2023 · 13a5dc4 · 13a5dc4
1 parent 4968d00
commit 13a5dc4
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -25,4 +25,18 @@ module.exports = {
       },
     },
   ],
+  rules: {
+    'no-restricted-properties': [2,
+      {
+        object: `semver`,
+        property: `validRange`,
+        message: `Use 'semverUtils.validRange' instead`,
+      },
+      {
+        object: `semver`,
+        property: `Range`,
+        message: `Use 'semverUtils.validRange' instead`,
+      },
+    ],
+  },
 };
diff --git a/.yarn/versions/e2989261.yml b/.yarn/versions/e2989261.yml
@@ -0,0 +1,2 @@
+declined:
+  - "@yarnpkg/core"
diff --git a/packages/yarnpkg-core/sources/semverUtils.ts b/packages/yarnpkg-core/sources/semverUtils.ts
@@ -25,6 +25,7 @@ export function satisfiesWithPrereleases(version: string | null, range: string,
   let semverRange = satisfiesWithPrereleasesCache.get(key);
   if (typeof semverRange === `undefined`) {
     try {
+      // eslint-disable-next-line no-restricted-properties
       semverRange = new semver.Range(range, {includePrerelease: true, loose});
     } catch {
       return false;
@@ -74,6 +75,7 @@ export function validRange(potentialRange: string): semver.Range | null {
     return range;
 
   try {
+    // eslint-disable-next-line no-restricted-properties
     range = new semver.Range(potentialRange);
   } catch {
     range = null;