Feature check sbml success #118
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #118 +/- ##
===========================================
+ Coverage 77.85% 87.15% +9.30%
===========================================
Files 5 6 +1
Lines 429 475 +46
===========================================
+ Hits 334 414 +80
+ Misses 95 61 -34
Continue to review full report at Codecov.
|
yaml2sbml/yaml2sbml.py
Outdated
| f'{species_id}, libsbml can not parse the right ' | ||
| f'hand side, given by {formula}).') |
There was a problem hiding this comment.
| f'{species_id}, libsbml can not parse the right ' | |
| f'hand side, given by {formula}).') | |
| f'{species_id}, libsbml can not parse the right-' | |
| f'hand side, given by {formula}).') |
| raise RuntimeError(f'Unable to generate assignment for formula ' | ||
| f'{formula}, libsbml can not parse the given ' | ||
| f'expression.') |
There was a problem hiding this comment.
| raise RuntimeError(f'Unable to generate assignment for formula ' | |
| f'{formula}, libsbml can not parse the given ' | |
| f'expression.') | |
| raise RuntimeError('Unable to generate assignment for formula ' | |
| f'{formula}, libsbml can not parse the given ' | |
| 'expression.') |
There was a problem hiding this comment.
would also work, matter of style I guess
There was a problem hiding this comment.
I think I once had a style checker complain about this :D So slightly in favor of leaving it consistent :)
|
@dilpath There is a weird AMICI issue when importing AMICI in the notebook tests, that was not there yesterday (since then only the string of Error messages changed, but not the code in this PR). Do you have any idea, why this could be the case? |
Adds additional checks when the SBML is created, if e.g. parameter/species creation was successful (i.e. if the id is a valid SBML identifier) and if the math can be parsed...