fix notebooks fixes #114 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #117 +/- ##
============================================
+ Coverage 77.85% 88.72% +10.86%
============================================
Files 5 6 +1
Lines 429 461 +32
============================================
+ Hits 334 409 +75
+ Misses 95 52 -43
Continue to review full report at Codecov.
|
yannikschaelte
approved these changes
Mar 7, 2021
| @@ -79,7 +79,9 @@ | |||
| " \n", | |||
| " model.add_ode(state_id = f\"x_{r}_{p}\", \n", | |||
| " right_hand_side=rhs,\n", | |||
| " initial_value=poisson.pmf(r, lambda_r)*poisson.pmf(p, lambda_p))\n", | |||
| " #convert from np.float to float\n", | |||
There was a problem hiding this comment.
might be good to perform float conversion inside the model always.
There was a problem hiding this comment.
Marta once suggested to use pydantic here. Agree, that we should think of adding type-checks inside of the Model Editor
This was referenced Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed two issues in the notebooks