Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo license; fixes #108 #116

Merged
merged 3 commits into from
Mar 7, 2021
Merged

Add logo license; fixes #108 #116

merged 3 commits into from
Mar 7, 2021

Conversation

yannikschaelte
Copy link
Member

No description provided.

@yannikschaelte yannikschaelte self-assigned this Mar 6, 2021
@codecov-io
Copy link

codecov-io commented Mar 6, 2021

Codecov Report

Merging #116 (4bf0302) into develop (3c45897) will increase coverage by 10.86%.
The diff coverage is 90.78%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #116       +/-   ##
============================================
+ Coverage    77.85%   88.72%   +10.86%     
============================================
  Files            5        6        +1     
  Lines          429      461       +32     
============================================
+ Hits           334      409       +75     
+ Misses          95       52       -43     
Impacted Files Coverage Δ
yaml2sbml/YamlModel.py 84.00% <77.77%> (-0.49%) ⬇️
yaml2sbml/yaml_validation.py 89.65% <77.77%> (+17.65%) ⬆️
yaml2sbml/yaml2sbml.py 89.86% <92.10%> (+14.48%) ⬆️
yaml2sbml/__init__.py 100.00% <100.00%> (ø)
yaml2sbml/version.py 100.00% <100.00%> (ø)
yaml2sbml/yaml2PEtab.py 94.17% <100.00%> (+23.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4bbf43...4bf0302. Read the comment docs.

Copy link
Member

@jvanhoefer jvanhoefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yannikschaelte yannikschaelte merged commit 0157684 into develop Mar 7, 2021
@yannikschaelte yannikschaelte deleted the logo_license branch March 7, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants