-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force cython when building sdist (see 196 instead) #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg2m!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Would have helped me not create the bad 4.1 dist.
The warning probably shouldn't be in setup.py for default usage though- otherwise anyone who installs from sdist will get it. Better to have a test to make sure the dist looks like we want. |
@nitzmahone this error will only happen for packagers and not for normal users during install. If you want to convince yourself, check out this branch, build the sdist with |
I think @nitzmahone meant the warning, not the error. |
ah! I should learn to read more carefully :) yeah the warning probably isn't necessary given we'll have the |
I created #196 |
Fixes #182
thanks @asottile
Alternatively there's #33 which will only issue a warning