-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update Node.js engine to >=18.20.0 #239
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues flagged.
Standard Input can make mistakes. Check important info.
📝 WalkthroughWalkthroughThe pull request modifies the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package.json (1)
86-86
: Consider documenting this change in release notesSince this is a change in the minimum Node.js version requirement, it would be helpful to:
- Document this change in CHANGELOG.md (if exists)
- Mention it in the next release notes
- Consider adding a note in README.md about Node.js version requirements
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 44 44
Lines 2108 2108
Branches 462 462
=======================================
Hits 1945 1945
Misses 163 163 ☔ View full report in Codecov by Sentry. |
Hi @massdo! Thank you for your pull request and sorry for the late response! I really appreciate you not only finding the issue, but also taking the time to create a pull request to fix it! I'll add a commit to update matrix:
node-version: ['18.20.0', '18.x', '20.x', '22.x', '23.x'] And by the way, thanks for noticing the project growth since your |
c81c9cc
to
e744deb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ci.yml
(2 hunks)package.json
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- package.json
🔇 Additional comments (1)
.github/workflows/ci.yml (1)
95-95
: LGTM! Node.js version matrix updated correctly.The addition of Node.js 18.20.0 to the test and build matrices aligns well with the PR objectives and ensures compatibility testing across both the specific minimum version and newer releases.
Also applies to: 138-138
@massdo |
Hi!
The last time I was here, it was to suggest adding
.repopackignore
. It’s great to see how much the project has grown congrats! 😊Summary
Updated the
engines.node
field inpackage.json
to"node": ">=18.20.0"
. This ensures compatibility with dependencies and fixes runtime and test issues with older versions.Why
Checklist
npm run test
npm run lint