🛠️ eslint

.eslintrc.yml

@@ -8,5 +8,8 @@ parserOptions:
   ecmaVersion: latest
   sourceType: module
   project: ./tsconfig.json
-rules: {}
+rules:  
+  '@typescript-eslint/consistent-type-imports':  
+    - 'error'  
+    - prefer: 'type-imports'
 ignorePatterns: ["styles.css"]

README.md

@@ -3,6 +3,7 @@
 <p align="center">
 		<img src="https://img.shields.io/github/release-date/yaleiyale/obsidian-emo-uploader?style=for-the-badge">
       <img src="https://img.shields.io/github/downloads/yaleiyale/obsidian-emo-uploader/total?style=for-the-badge">
+      <img src="https://img.shields.io/codefactor/grade/github/yaleiyale/obsidian-emo-uploader/main?style=for-the-badge">
 </p>
 
 Embed markdown online file/image links.  

src/base/emo-fragment.ts

@@ -1,5 +1,5 @@
-import { HostingProvider } from '../config'
-import Emo from '../main'
+import type { HostingProvider } from '../config'
+import type Emo from '../main'
 
 export abstract class EmoFragment {
   kind: HostingProvider

src/base/emo-uploader.ts

@@ -1,4 +1,4 @@
-import { EmoParms } from './emo-parms'
+import type { EmoParms } from './emo-parms'
 
 export abstract class EmoUploader {
   parms!: EmoParms

src/config.ts

@@ -1,12 +1,21 @@
-import { CatboxParms, CATBOX_DEFAULT_PARMS } from './parms/parms-catbox'
-import { CHEVERETO_DEFAULT_PARMS, CheveretoParms } from './parms/parms-chevereto'
-import { CloudinaryParms, CLOUDINARY_DEFAULT_PARMS } from './parms/parms-cloudinary'
-import { GithubParms, GITHUB_DEFAULT_PARMS } from './parms/parms-github'
-import { ImgbbParms, IMGBB_DEFAULT_PARMS } from './parms/parms-imgbb'
-import { ImgurParms, IMGUR_DEFAULT_PARMS } from './parms/parms-imgur'
-import { ImgurlParms, IMGURL_DEFAULT_PARMS } from './parms/parms-imgurl'
-import { SmmsParms, SMMS_DEFAULT_PARMS } from './parms/parms-smms'
-import { ALIST_DEFAULT_PARMS, AlistParms } from './parms/parms-alist'
+import type { CatboxParms } from './parms/parms-catbox'
+import { CATBOX_DEFAULT_PARMS } from './parms/parms-catbox'
+import type { CheveretoParms } from './parms/parms-chevereto'
+import { CHEVERETO_DEFAULT_PARMS } from './parms/parms-chevereto'
+import type { CloudinaryParms } from './parms/parms-cloudinary'
+import { CLOUDINARY_DEFAULT_PARMS } from './parms/parms-cloudinary'
+import type { GithubParms } from './parms/parms-github'
+import { GITHUB_DEFAULT_PARMS } from './parms/parms-github'
+import type { ImgbbParms } from './parms/parms-imgbb'
+import { IMGBB_DEFAULT_PARMS } from './parms/parms-imgbb'
+import type { ImgurParms } from './parms/parms-imgur'
+import { IMGUR_DEFAULT_PARMS } from './parms/parms-imgur'
+import type { ImgurlParms } from './parms/parms-imgurl'
+import { IMGURL_DEFAULT_PARMS } from './parms/parms-imgurl'
+import type { SmmsParms } from './parms/parms-smms'
+import { SMMS_DEFAULT_PARMS } from './parms/parms-smms'
+import type { AlistParms } from './parms/parms-alist'
+import { ALIST_DEFAULT_PARMS } from './parms/parms-alist'
 
 export interface Config { // data from data.json
   choice: HostingProvider

src/fragment/fragment-alist.ts

@@ -1,5 +1,5 @@
 import { Setting } from 'obsidian'
-import Emo from '../main'
+import type Emo from '../main'
 import { EmoFragment } from '../base/emo-fragment'
 import { HostingProvider } from '../config'
 import { t } from '../lang/helpers'

src/fragment/fragment-catbox.ts

@@ -1,5 +1,5 @@
 import { Setting } from 'obsidian'
-import Emo from '../main'
+import type Emo from '../main'
 import { EmoFragment } from '../base/emo-fragment'
 import { HostingProvider } from '../config'
 import { t } from '../lang/helpers'

src/fragment/fragment-chevereto.ts

@@ -1,5 +1,5 @@
 import { Setting } from 'obsidian'
-import Emo from '../main'
+import type Emo from '../main'
 import { EmoFragment } from '../base/emo-fragment'
 import { HostingProvider } from '../config'
 import { t } from '../lang/helpers'

src/fragment/fragment-cloudinary.ts

@@ -1,5 +1,5 @@
 import { Setting } from 'obsidian'
-import Emo from '../main'
+import type Emo from '../main'
 import { EmoFragment } from '../base/emo-fragment'
 import { HostingProvider } from '../config'
 import { t } from '../lang/helpers'

src/fragment/fragment-github.ts

@@ -1,5 +1,5 @@
 import { Setting } from 'obsidian'
-import Emo from '../main'
+import type Emo from '../main'
 import { EmoFragment } from '../base/emo-fragment'
 import { HostingProvider } from '../config'
 import { t } from '../lang/helpers'

src/fragment/fragment-imgbb.ts

@@ -1,5 +1,5 @@
 import { Setting } from 'obsidian'
-import Emo from '../main'
+import type Emo from '../main'
 import { EmoFragment } from '../base/emo-fragment'
 import { HostingProvider } from '../config'
 import { t } from '../lang/helpers'

src/fragment/fragment-imgur.ts

@@ -1,5 +1,6 @@
-import { ButtonComponent, Notice, request, RequestUrlParam, Setting } from 'obsidian'
-import Emo from '../main'
+import type { ButtonComponent, RequestUrlParam } from 'obsidian'
+import { Notice, request, Setting } from 'obsidian'
+import type Emo from '../main'
 import { EmoFragment } from '../base/emo-fragment'
 import { HostingProvider } from '../config'
 import { IMGUR_ACCESS_TOKEN_LOCALSTORAGE_KEY, IMGUR_DEFAULT_ID } from '../base/constants'

src/fragment/fragment-imgurl.ts

@@ -1,5 +1,5 @@
 import { Setting } from 'obsidian'
-import Emo from '../main'
+import type Emo from '../main'
 import { EmoFragment } from '../base/emo-fragment'
 import { HostingProvider } from '../config'
 import { t } from '../lang/helpers'

src/fragment/fragment-smms.ts

@@ -1,5 +1,5 @@
 import { Setting } from 'obsidian'
-import Emo from '../main'
+import type Emo from '../main'
 import { EmoFragment } from '../base/emo-fragment'
 import { HostingProvider } from '../config'
 import { t } from '../lang/helpers'

src/main.ts

@@ -1,12 +1,13 @@
+import type { Editor } from 'obsidian'
 import {
   Plugin,
-  Editor,
   Notice
 } from 'obsidian'
 import { t } from './lang/helpers'
 import { EmoUploaderSettingTab } from './settings-tab'
-import { Config, DEFAULT_SETTINGS, HostingProvider } from './config'
-import { EmoUploader } from './base/emo-uploader'
+import type { Config } from './config'
+import { DEFAULT_SETTINGS, HostingProvider } from './config'
+import type { EmoUploader } from './base/emo-uploader'
 import { GithubUploader } from './uploader/uploader-github'
 import { ImgurlUploader } from './uploader/uploader-imgurl'
 import { CloudinaryUploader } from './uploader/uploader-cloudinary'

src/parms/parms-alist.ts

@@ -1,4 +1,4 @@
-import { EmoParms } from '../base/emo-parms'
+import type { EmoParms } from '../base/emo-parms'
 
 export interface AlistParms extends EmoParms {
   required: Required

src/parms/parms-catbox.ts

@@ -1,4 +1,4 @@
-import { EmoParms } from '../base/emo-parms'
+import type { EmoParms } from '../base/emo-parms'
 
 export interface CatboxParms extends EmoParms {
   required: Required

src/parms/parms-chevereto.ts

@@ -1,4 +1,4 @@
-import { EmoParms } from '../base/emo-parms'
+import type { EmoParms } from '../base/emo-parms'
 
 export interface CheveretoParms extends EmoParms {
   required: Required

src/parms/parms-cloudinary.ts

@@ -1,4 +1,4 @@
-import { EmoParms } from '../base/emo-parms'
+import type { EmoParms } from '../base/emo-parms'
 
 export interface CloudinaryParms extends EmoParms {
   required: Required

src/parms/parms-github.ts

@@ -1,4 +1,4 @@
-import { EmoParms } from '../base/emo-parms'
+import type { EmoParms } from '../base/emo-parms'
 export enum CDNprovider { // Github CDN
   jsdelivr = 'jsdelivr',
   statically = 'statically',

src/parms/parms-imgbb.ts

@@ -1,4 +1,4 @@
-import { EmoParms } from '../base/emo-parms'
+import type { EmoParms } from '../base/emo-parms'
 
 export interface ImgbbParms extends EmoParms {
   required: Required

src/parms/parms-imgur.ts

@@ -1,4 +1,4 @@
-import { EmoParms } from '../base/emo-parms'
+import type { EmoParms } from '../base/emo-parms'
 
 export interface ImgurParms extends EmoParms {
   required: Required

src/parms/parms-imgurl.ts

@@ -1,4 +1,4 @@
-import { EmoParms } from '../base/emo-parms'
+import type { EmoParms } from '../base/emo-parms'
 
 export interface ImgurlParms extends EmoParms {
   required: Required

src/parms/parms-smms.ts

@@ -1,4 +1,4 @@
-import { EmoParms } from '../base/emo-parms'
+import type { EmoParms } from '../base/emo-parms'
 
 export interface SmmsParms extends EmoParms {
   required: Required

src/settings-tab.ts

@@ -1,13 +1,13 @@
+import type { App } from 'obsidian'
 import {
-  App,
   Notice,
   PluginSettingTab,
   Setting
 } from 'obsidian'
 import { HostingProvider } from './config'
-import Emo from './main'
+import type Emo from './main'
 import { t } from './lang/helpers'
-import { EmoFragment } from './base/emo-fragment'
+import type { EmoFragment } from './base/emo-fragment'
 import { CloudinaryFragment } from './fragment/fragment-cloudinary'
 import { GithubFragment } from './fragment/fragment-github'
 import { ImgbbFragment } from './fragment/fragment-imgbb'

src/uploader/uploader-alist.ts

@@ -1,9 +1,10 @@
 // 第一部分
-import { request, RequestUrlParam } from 'obsidian'
+import type { RequestUrlParam } from 'obsidian'
+import { request } from 'obsidian'
 import { EmoFormData } from '../utils/emo-formdata'
 import { EmoUploader } from '../base/emo-uploader'
 import { CONTENT_TYPE_FORMDATA } from '../base/constants'
-import { AlistParms } from '../parms/parms-alist'
+import type { AlistParms } from '../parms/parms-alist'
 import { sha256 } from 'js-sha256'
 
 export class AlistUploader extends EmoUploader {

src/uploader/uploader-catbox.ts

@@ -1,8 +1,9 @@
-import { request, RequestUrlParam } from 'obsidian'
+import type { RequestUrlParam } from 'obsidian'
+import { request } from 'obsidian'
 import { EmoFormData } from '../utils/emo-formdata'
 import { EmoUploader } from '../base/emo-uploader'
 import { CONTENT_TYPE_FORMDATA } from '../base/constants'
-import { CatboxParms } from '../parms/parms-catbox'
+import type { CatboxParms } from '../parms/parms-catbox'
 
 export class CatboxUploader extends EmoUploader {
   parms!: CatboxParms

src/uploader/uploader-chevereto.ts

@@ -1,6 +1,7 @@
-import { request, RequestUrlParam } from 'obsidian'
+import type { RequestUrlParam } from 'obsidian'
+import { request } from 'obsidian'
 import { EmoUploader } from '../base/emo-uploader'
-import { CheveretoParms } from '../parms/parms-chevereto'
+import type { CheveretoParms } from '../parms/parms-chevereto'
 import { EmoFormData } from '../utils/emo-formdata'
 import { CONTENT_TYPE_FORMDATA } from '../base/constants'
 

src/uploader/uploader-cloudinary.ts

@@ -1,5 +1,6 @@
-import { request, RequestUrlParam } from 'obsidian'
-import { CloudinaryParms } from '../parms/parms-cloudinary'
+import type { RequestUrlParam } from 'obsidian'
+import { request } from 'obsidian'
+import type { CloudinaryParms } from '../parms/parms-cloudinary'
 import { EmoFormData } from '../utils/emo-formdata'
 import { EmoUploader } from '../base/emo-uploader'
 import { CONTENT_TYPE_FORMDATA } from '../base/constants'

src/uploader/uploader-github.ts

@@ -1,5 +1,7 @@
-import { request, RequestUrlParam } from 'obsidian'
-import { CDNprovider, GithubParms } from '../parms/parms-github'
+import type { RequestUrlParam } from 'obsidian'
+import { request } from 'obsidian'
+import type { GithubParms } from '../parms/parms-github'
+import { CDNprovider } from '../parms/parms-github'
 import { getBase64, getRandomFileName } from '../utils/file-helper'
 import { EmoUploader } from '../base/emo-uploader'
 

src/uploader/uploader-imgbb.ts

@@ -1,5 +1,6 @@
-import { request, RequestUrlParam } from 'obsidian'
-import { ImgbbParms } from '../parms/parms-imgbb'
+import type { RequestUrlParam } from 'obsidian'
+import { request } from 'obsidian'
+import type { ImgbbParms } from '../parms/parms-imgbb'
 import { EmoFormData } from '../utils/emo-formdata'
 import { EmoUploader } from '../base/emo-uploader'
 import { CONTENT_TYPE_FORMDATA } from '../base/constants'

src/uploader/uploader-imgur.ts

@@ -1,5 +1,6 @@
-import { request, RequestUrlParam } from 'obsidian'
-import { ImgurParms } from '../parms/parms-imgur'
+import type { RequestUrlParam } from 'obsidian'
+import { request } from 'obsidian'
+import type { ImgurParms } from '../parms/parms-imgur'
 import { EmoFormData } from '../utils/emo-formdata'
 import { EmoUploader } from '../base/emo-uploader'
 import { CONTENT_TYPE_FORMDATA, IMGUR_ACCESS_TOKEN_LOCALSTORAGE_KEY, IMGUR_DEFAULT_ID } from '../base/constants'

src/uploader/uploader-imgurl.ts

@@ -1,5 +1,6 @@
-import { request, RequestUrlParam } from 'obsidian'
-import { ImgurlParms } from '../parms/parms-imgurl'
+import type { RequestUrlParam } from 'obsidian'
+import { request } from 'obsidian'
+import type { ImgurlParms } from '../parms/parms-imgurl'
 import { EmoFormData } from '../utils/emo-formdata'
 import { EmoUploader } from '../base/emo-uploader'
 import { CONTENT_TYPE_FORMDATA } from '../base/constants'

src/uploader/uploader-smms.ts

@@ -1,5 +1,6 @@
-import { request, RequestUrlParam } from 'obsidian'
-import { SmmsParms } from '../parms/parms-smms'
+import type { RequestUrlParam } from 'obsidian'
+import { request } from 'obsidian'
+import type { SmmsParms } from '../parms/parms-smms'
 import { EmoFormData } from '../utils/emo-formdata'
 import { EmoUploader } from '../base/emo-uploader'
 import { CONTENT_TYPE_FORMDATA } from '../base/constants'