Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS vulnerable to ally unhappiness #5134

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Conversation

SimonCeder
Copy link
Collaborator

As mentioned in #4602.
If the ally of a city state has negative unhappiness, the city state's units are affected as well.

@yairm210 yairm210 merged commit 7297139 into yairm210:master Sep 8, 2021
@ajustsomebody ajustsomebody mentioned this pull request Sep 11, 2021
26 tasks
@xlenstra
Copy link
Collaborator

xlenstra commented Jan 7, 2022

I was looking into this, and while this is indeed remarked on the wiki, I couldn't find any source for this in the source code. Did you find any code for it when implementing this?

@SimonCeder
Copy link
Collaborator Author

I don't think so. Probably the wiki being wrong yet again. Relevant code seems to be GetGenericMaxStrengthModifier in CvUnit.cpp, there is a flat -33% penalty for very unhappy (<= -10 happiness) but only counting the happiness of the civ owning the unit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants