City states adjustments

[SimonCeder]

Adds extra checks for city states to make them behave more like Civ V

• City states spawn only with one settler regardless of difficulty and era
• City states will not explore more than one hex outside their territory. They will still go after barbarians and enemy civs.
• EDIT: Added factors for slower production, pop growth, and border expansion for city states.
• Default number of city states in a new game is now 8 (the Civ V default; they are now less annoying than before)

[xlenstra]

Based on a quick skim of the source code for the base game, city states require 1.5 times as much culture for border expansion

[ajustsomebody]

should i open a todo list issue that has missing features for city states?

[xlenstra]

should i open a todo list issue that has missing features for city states?

Sure! I would advise on putting it in #663, but that would save us work on figuring it all out

[ajustsomebody]

should i open a todo list issue that has missing features for city states?

Sure! I would advise on putting it in #663, but that would save us work on figuring it all out

i think #663 is too cluttered, i will open the thread tomorrow if it is okay

[SimonCeder]

should i open a todo list issue that has missing features for city states?

That would be very helpful!

Based on a quick skim of the source code for the base game, city states require 1.5 times as much culture for border expansion

So it is! m_iMINOR_CIV_PLOT_CULTURE_COST_MULTIPLIER(150), CvGlobals.cpp. For some reason I never thought to look. Adjusted. Turns out there are also multipliers for growth, production, etc.

[ravignir]

• Default number of city states in a new game is now 8 (the Civ V default; they are now less annoying than before)

Yes, but civ5 map is bigger(56×36), unciv is (44x29).
That feels more like 3 civs/6 city states.

[ajustsomebody]

@SimonCeder @xlenstra done! #4602
also i have lot more mega-threads about issues, just in case yall might want to check them

[SimonCeder]

• Default number of city states in a new game is now 8 (the Civ V default; they are now less annoying than before)

Yes, but civ5 map is bigger(56×36), unciv is (44x29).
That feels more like 3 civs/6 city states.

Actually it should be 5 city states for the same density! 6 sounds good for now.

[yairm210]

Please don't use the word irregardless

[SomeTroglodyte]

🤣 I just had to check this discussion because I saw that creative word in Studio without the spellchecker whining - and - eagle eyes. I actually quite like it.

[SomeTroglodyte]

👍 I like where this is going went. Just one thing comes to mind: It might help future coders to see the quality of research backing some code decisions so they won't go and re-research. So a *= 1.5f // from original source code or similar could be useful someday. I get the current commenting is from before this discussion here - just - food for thought.