Ensure http method is always lowercase #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmat
changed the title
Envek
pushed a commit
that referenced
this pull request
Dec 14, 2023
Per RFC 7231 HTTP verbs are defined as case-sensitive and standard ones are in uppercase. See https://www.rfc-editor.org/rfc/rfc7231#section-4.1 Resolves #6
|
Hey, thanks for the pull request and sorry for the late reply. As per RFC 7231 HTTP verbs are defined as case-sensitive and standard ones are in uppercase. So I made the opposite to your implementation: upcased http verbs. Released in 0.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I've noticed that most of my http metrics have
methodlowercase (like yabeda-rails' metrics), but sometimes I have metrics wheremethodis uppercase. I assume this is a difference per http library.Here I'm suggesting a trivial change that would ensure it's always lowercase, to match yabeda-rails. Is there appetite for this kind of normalization?
This is a backwards incompatible change with regards to the metrics themselves. I can work to make the behaviour configurable if you want, although I think this would over-complicate things.