Make Sniffer work with Ruby 3.0 separation of kw args #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the release of ruby 3.0 (https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/) keyword and positional arguments are separated (https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/) In this case we need to explicitly pass a hash to the increment methods.
|
CI is failing due to rubocop saying it doesn't support ruby version 2.3 (specified in gemspec). Not sure what to do there (updating gemspec to 2.4 works but not sure if that's ok), please advise. |
|
Thank you very much! I will release new version a bit later. I decided to drop EOLed Rubies (anyway Sniffer requires at least 2.5) /cc @dsalahutdinov And now CI passes! ;-) |
|
Released in 0.2.0, thanks! |
|
Awesome, thanks @Envek ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of ruby 3.0 (https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/)
keyword and positional arguments are separated (https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/)
In this case we need to explicitly pass a hash to the increment
methods.