fixed permissions/owner on parent folders #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GermanHydrogen
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Code wise it looks good for me.
Conceptionally it feels like, that it does not fix the underlying problem.
This is now probably convenient to use, but now it is not possible to create other states.
Could be fixed by introducing a function to create a filesystem by parsing a config.
Maybe something for the future...
Yes, I had this idea too. I created a ticket for that. #352 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this pr will fix the linked issue. See issue for details.