fix: docker-compose mandates COMMIT_HASH arg

docker/compose#3608 (comment)
y-young · Apr 11, 2023 · 3176a68 · 3176a68
1 parent fc2366d
commit 3176a68
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -16,10 +16,10 @@ COPY react/ .
 
 RUN mkdir /app/public
 
-ARG COMMIT_HASH=unknown
+ARG COMMIT_HASH
 ARG VITE_SENTRY_DSN
 
-ENV COMMIT_HASH=$COMMIT_HASH
+ENV COMMIT_HASH=${COMMIT_HASH:-"unknown"}
 ENV VITE_SENTRY_DSN=$VITE_SENTRY_DSN
 
 RUN pnpm build

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -9,8 +9,8 @@ services:
       dockerfile: ./Dockerfile
       target: production
       args:
-        - VITE_SENTRY_DSN
-        - COMMIT_HASH
+        VITE_SENTRY_DSN: ${VITE_SENTRY_DSN:-}
+        COMMIT_HASH: ${COMMIT_HASH:-}
     volumes:
       - ./config:/var/www/html/config
       - storage:/var/www/html/storage