Skip to content

Commit

Permalink
bpo-39349: Add cancel_futures to Executor.shutdown base class (python…
Browse files Browse the repository at this point in the history
…GH-22023)

* Add cancel_futures parameter to the Executor base class, since it was missed in the original PR (python#18057) that added cancel_futures.
  • Loading branch information
hauntsaninja authored and Seth Sims committed Oct 18, 2020
1 parent cb998cc commit 2e88380
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion Lib/concurrent/futures/_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ def result_iterator():
future.cancel()
return result_iterator()

def shutdown(self, wait=True):
def shutdown(self, wait=True, *, cancel_futures=False):
"""Clean-up the resources associated with the Executor.
It is safe to call this method several times. Otherwise, no other
Expand All @@ -615,6 +615,9 @@ def shutdown(self, wait=True):
wait: If True then shutdown will not return until all running
futures have finished executing and the resources used by the
executor have been reclaimed.
cancel_futures: If True then shutdown will cancel all pending
futures. Futures that are completed or running will not be
cancelled.
"""
pass

Expand Down

0 comments on commit 2e88380

Please sign in to comment.