This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs to client and display
…nt; ensure data migration accounts for dirty
This reverts commit 7e30012.
Check for unauthorized, unrecognized, and invalid settings prior to sanitizing
… into feature/refactor
* Remove bulk actions filter * Replace publish filter with transition filter. * Remove hiding of publish metabox if not current theme. Allow publishing if not current theme. * Remove hiding of author metabox. * Remove extraneous info now that publish metabox is restored. * Move Post_Type logic to Customize_Snapshot_Manager
…endnecy; fix tests
Add initial read-only REST API endpoints for snapshots
…e-snapshots into feature/publish-snapshot
…ed_publishing_actions
Allow snapshot posts to publish and be scheduled
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the past week, off-and-on, I've done a deep dive into the snapshots PHP code and I believe I've come up with an improved refactored codebase that cleans out some cruft and improves maintainability.
can_preview
method: only users who have the setting's capability can write to the snapshot, so everyone should be able to freely preview what has been stored there.dirty
flag in the post data. We're only storing the changed values. Because of this, we can now simplify the snapshot data to just be the values. We can skip storing a sanitized flag as well, however this needs more discovery.get_permalink()
returns the frontend URL for the site with thecustomize_snapshot_uuid
param added.Todos:
PR originally opened to
master
in #53