Feat wasm bigint #1
Conversation
src/compiler/wasm-compiler.cc
Outdated
| index, | ||
| RelocInfo::WASM_STUB_CALL) | ||
| : jsgraph()->HeapConstant( | ||
| BUILTIN_CODE(isolate_, WasmToBigIntJavaScript)); |
There was a problem hiding this comment.
Dumb question (I haven't worked with CSA before): Rather than calling this runtime stub, would it work to call CodeStubAssembler::BigIntFromInt64 directly, or write code that's similar to BuildChangeInt32ToTagged to do accomplish this task?
There was a problem hiding this comment.
Your question make sense and it would be possible in JS, wasm has a additionnal restriction for calling its runtime stubs, see https://github.com/xtuc/v8/pull/1/files/dda86c1f2fc8c7dfee946527154ae5cccffde6a4#diff-74de4cf1fe91d141c93cad45c7cb81e0R4357. It's more or less a workarround.
There was a problem hiding this comment.
There was a problem hiding this comment.
Hmm, is BuildChangeInt32ToTagged a runtime stub, or just a bunch of compiler IR that gets generated inline? I thought it was the latter, and that's what I'm suggesting be done here.
There was a problem hiding this comment.
BuildChangeInt32ToTagged generates IR, what you're suggesting is interesting, it could avoid the additional procedure call. I think that I could generate the IR directly too, thanks for your suggestion!
There was a problem hiding this comment.
I'm not sure how to do because I'd like to use the code in BigIntFromInt64 on the CSA. BuildChangeInt32ToTagged is a bit simplier and probably not existing already on the CSA.
There was a problem hiding this comment.
How I implemented is consistent with the other wasm buitilns or trampolines to builtin. Howerver, the code structure is wrong.
There was a problem hiding this comment.
I think it'd be OK to go down either of these paths, as BigInts have significant performance overhead anyway (though my personal preference would be the faster one--maybe you can work out how to share the code).
There was a problem hiding this comment.
I though about that also, the conversion only happen at the JS boudaries. In wasm it's a unboxed int64 type.
Howerver, I'd like to make it right first.
xtuc
force-pushed
the
feat-wasm-bigint
branch
from
dda86c1 to
95ac1e9
Compare
xtuc
force-pushed
the
feat-wasm-bigint
branch
2 times, most recently
from
2fa1350 to
85eadb4
Compare
xtuc
force-pushed
the
feat-wasm-bigint
branch
from
85eadb4 to
340d33e
Compare
Creating PR to make review comments