Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SelectionManager more resilient #810

Merged
merged 2 commits into from
Jul 21, 2017
Merged

Make SelectionManager more resilient #810

merged 2 commits into from
Jul 21, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 21, 2017

Fixes #809

@Tyriar Tyriar added this to the 2.9.0 milestone Jul 21, 2017
@Tyriar Tyriar self-assigned this Jul 21, 2017
@Tyriar Tyriar requested a review from parisk July 21, 2017 12:46
@coveralls
Copy link

coveralls commented Jul 21, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 70.396% when pulling e56f710 on Tyriar:809_onSingleClick_null_check into 18f3cc7 on sourcelair:master.

@blink1073
Copy link
Contributor

Something we have done in JupyterLab is temporarily turn on strictNullChecks and fix as many local errors as we can, and then turn the flag off. We have a couple of type system restrictions that prevent us from turning it on permanently. One annoying thing is that getComputedStyle attributes are all possibly null, leading to style.width! (notice the null assertion operator).

@Tyriar
Copy link
Member Author

Tyriar commented Jul 21, 2017

It would be good to be as strict as possible eventually, can't wait until #335 is done

parisk
parisk approved these changes Jul 21, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 70.396% when pulling bbb5daa on Tyriar:809_onSingleClick_null_check into 739bd05 on sourcelair:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 70.396% when pulling bbb5daa on Tyriar:809_onSingleClick_null_check into 739bd05 on sourcelair:master.

@Tyriar Tyriar merged commit 2e9177a into xtermjs:master Jul 21, 2017
@Tyriar Tyriar deleted the 809_onSingleClick_null_check branch July 21, 2017 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Tyriar @coveralls @blink1073 @parisk