Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Viewport to TypeScript #370

Merged
merged 4 commits into from
Nov 22, 2016
Merged

Convert Viewport to TypeScript #370

merged 4 commits into from
Nov 22, 2016

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Nov 21, 2016

Part of #335

The e0d9871 diff which includes the changes for Viewport.ts may be a little easier to read conpared to the diff in the PR.

parisk
parisk approved these changes Nov 22, 2016
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Branchs works great 👍 , code looks great 👍 .

@Tyriar Tyriar merged commit 20b0d4f into xtermjs:master Nov 22, 2016
@Tyriar Tyriar deleted the 335_Viewport_ts branch November 22, 2016 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @parisk