Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output is all messed up when running apt install/remove #818

Closed
Tyriar opened this issue Jul 24, 2017 · 4 comments
Closed

Output is all messed up when running apt install/remove #818

Tyriar opened this issue Jul 24, 2017 · 4 comments
Assignees
@Tyriar
Labels
important type/bug Something is misbehaving
Milestone
2.9.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 24, 2017

Seems related to the progress bar is uses.

microsoft/vscode#31339
@Tyriar Tyriar added the type/bug Something is misbehaving label Jul 24, 2017
@Tyriar Tyriar added this to the 2.9.0 milestone Jul 24, 2017
@Tyriar Tyriar self-assigned this Jul 24, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Jul 27, 2017

It appears to be a regression from the buffer refactor #717

@parisk
Copy link
Contributor

parisk commented Jul 27, 2017

Quite interesting. Do you have any quick thoughts on why this might be happening or should I just start digging into it?

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 27, 2017
@Tyriar
Fix save and restore cursor behavior
604959a 
This broke in xtermjs#717.

Fixes xtermjs#818
@Tyriar Tyriar mentioned this issue Jul 27, 2017
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Jul 27, 2017

@parisk took me most of the day to figure it out 😛 fix is in #822

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jul 27, 2017
@Tyriar
Fix save and restore cursor behavior
3b3f992 
This broke in xtermjs#717.

Fixes xtermjs#818
@parisk
Copy link
Contributor

parisk commented Jul 28, 2017

Awesome, just reviewed it. Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
important type/bug Something is misbehaving
Projects
None yet
Milestone
2.9.0
Development

No branches or pull requests
2 participants
@parisk @Tyriar