Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big output in tmux (application) mode breaks rendering #434

Closed
parisk opened this issue Dec 31, 2016 · 4 comments
Closed

Big output in tmux (application) mode breaks rendering #434

parisk opened this issue Dec 31, 2016 · 4 comments
Assignees
@Tyriar
Labels
important type/bug Something is misbehaving
Milestone
2.3.0

Comments

@parisk
Copy link
Contributor

parisk commented Dec 31, 2016 •
edited
Loading

Printing lots of output in tmux (application) mode results in broken rendering

Details

  • Browser and browser version: Chrome 55
  • OS version: macOS
  • xterm.js version: 23472e6

Steps to reproduce

  1. Run the demo and open it in the browser
  2. Run tmux
  3. Run ls -lR into xterm.js' directory

Screenshots

tmux

image

ls -lR (no tmux status bar)

image
@parisk parisk added type/bug Something is misbehaving rendering labels Dec 31, 2016
@parisk parisk mentioned this issue Dec 31, 2016
Closed
@parisk
Copy link
Contributor Author

parisk commented Dec 31, 2016

Noting also that this produces no console logs or errors at all.

@Tyriar
Copy link
Member

Tyriar commented Dec 31, 2016

Does this happen before the circular list?

@parisk
Copy link
Contributor Author

parisk commented Dec 31, 2016

Likely not. Tried this on SourceLair (which uses 2.2) and the output gets rendered fine.

image

@parisk parisk changed the title Bug output in tmux (application) mode breaks rendering Big output in tmux (application) mode breaks rendering Dec 31, 2016
@Tyriar
Copy link
Member

Tyriar commented Dec 31, 2016

I think I know what caused this.

@Tyriar Tyriar self-assigned this Dec 31, 2016
@Tyriar Tyriar added this to the 2.3.0 milestone Dec 31, 2016
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Dec 31, 2016
@Tyriar
Fix scroll in tmux with max scrollback
6721b8d 
I believe this is related to when scrollBottom is not the last row in the viewport

Fixes xtermjs#434
@Tyriar Tyriar mentioned this issue Dec 31, 2016
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Dec 31, 2016
@Tyriar
Fix scroll in tmux with max scrollback
c3f46e4 
I believe this is related to when scrollBottom is not the last row in the viewport

Fixes xtermjs#434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
important type/bug Something is misbehaving
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
2 participants
@parisk @Tyriar