Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow p:filter to return non-node results #645

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Allow p:filter to return non-node results #645

merged 1 commit into from
Jan 5, 2025

Conversation

ndw
Copy link
Collaborator

@ndw ndw commented Dec 24, 2024

Fix #644

@ndw ndw requested a review from a team as a code owner December 24, 2024 14:06
@ndw ndw mentioned this pull request Dec 24, 2024
Merged
xml-project
xml-project approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@xml-project xml-project left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title is a bit confusing: The change does not only allow atomic values but also maps and arrays. But I think that is what we want.

@ndw ndw changed the title Allow p:filter to return atomic values Allow p:filter to return non-node results Dec 24, 2024
@ndw
Copy link
Collaborator Author

ndw commented Dec 24, 2024

Yeah. That was careless of me. I fixed the title. Well, I think I improved it, anyway 😄

@ndw ndw merged commit 282829e into xproc:master Jan 5, 2025
4 checks passed
@ndw ndw deleted the iss-644 branch January 5, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xml-project xml-project xml-project approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More problems with p:filter?
2 participants
@ndw @xml-project