Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to p:ixml #604

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Improvements to p:ixml #604

merged 4 commits into from
Aug 1, 2024

Conversation

ndw
Copy link
Collaborator

@ndw ndw commented Aug 1, 2024

For some reason, the build didn't include p:ixml. I fixed that.

I fixed #494 and #547.

I changed the content types of the source port given the new error changes.

@ndw ndw requested a review from a team as a code owner August 1, 2024 16:37
Copy link
Contributor

@gimsieke gimsieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a current rendering of the changed spec? The one on xproc.org dates from Nov 27, 2023.

@@ -5,7 +5,7 @@ repositories {

configurations {
tools {
description = "ixml tools"
description = "Run tools"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is just a human-processible info without any technical implication? (My first thought was that it was erroneously copied from p:run but now I think that it just says what it says.)

@ndw
Copy link
Collaborator Author

ndw commented Aug 1, 2024

Oh, bah humbug. This is another instance of a build change not reflected in a PR. I'll merge it and we can blame me if I borked int.

@ndw ndw merged commit 9eb025a into xproc:master Aug 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p:ixml should always wrap output into ixml element
2 participants