Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add admin module #62

Merged
merged 15 commits into from
Mar 5, 2022
Merged

feat: add admin module #62

merged 15 commits into from
Mar 5, 2022

Conversation

ArnabXD
Copy link
Member

@ArnabXD ArnabXD commented Feb 14, 2022

No description provided.

@ArnabXD ArnabXD changed the title feat: admin module - promote feat: admin module Feb 14, 2022
@ArnabXD ArnabXD linked an issue Feb 14, 2022 that may be closed by this pull request
3 tasks
@ArnabXD ArnabXD removed a link to an issue Feb 14, 2022
3 tasks
@ArnabXD ArnabXD linked an issue Feb 14, 2022 that may be closed by this pull request
@ArnabXD
Copy link
Member Author

ArnabXD commented Feb 14, 2022

Sorry for the spam lol, clicked outside by mistake twice.

@ArnabXD ArnabXD self-assigned this Feb 14, 2022
@rojvv rojvv changed the title feat: admin module feat: admin Feb 14, 2022
@rojvv rojvv added the feat label Feb 14, 2022
@rojvv rojvv marked this pull request as draft February 14, 2022 13:52
Copy link
Collaborator

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to the part of getting the entity to promote or to do an action on: you should make it a helper function to not duplicate it for all commands.

@rojvv
Copy link
Collaborator

rojvv commented Feb 15, 2022

Any updates?

@ArnabXD
Copy link
Member Author

ArnabXD commented Feb 15, 2022

no working updates yet, currently stucked on ban...

@rojvv
Copy link
Collaborator

rojvv commented Feb 15, 2022

Why stuck?

@rojvv
Copy link
Collaborator

rojvv commented Feb 15, 2022

Can't you separate "the part of getting the entity to promote or to do an action on" to a helper function before thinking about other commands?

@ArnabXD
Copy link
Member Author

ArnabXD commented Feb 15, 2022

the part of getting entity might look same but some additional steps are there, I didn't try DRY here because I was't sure if this will even worth if there is just this two cases. So I thought to - let's make them working and then refactor them properly.

Why stuck?

Because it is not banning the user (I know stupid answer but truth lol).

@ArnabXD ArnabXD marked this pull request as ready for review March 4, 2022 19:26
Copy link
Collaborator

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArnabXD You can merge this if you approve my changes, too.

@ArnabXD ArnabXD changed the title feat: admin feat: add admin module Mar 5, 2022
@ArnabXD ArnabXD merged commit a08383b into main Mar 5, 2022
@ArnabXD ArnabXD deleted the admin-module branch March 5, 2022 02:46
rojvv added a commit that referenced this pull request Jan 20, 2023
rojvv added a commit that referenced this pull request Jan 20, 2023
rojvv added a commit that referenced this pull request Jan 20, 2023
rojvv added a commit that referenced this pull request Jan 20, 2023
rojvv added a commit that referenced this pull request Jan 20, 2023
rojvv added a commit that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants