-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add admin module #62
Conversation
Sorry for the spam lol, clicked outside by mistake twice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to the part of getting the entity to promote or to do an action on: you should make it a helper function to not duplicate it for all commands.
Any updates? |
no working updates yet, currently stucked on ban... |
Why stuck? |
Can't you separate "the part of getting the entity to promote or to do an action on" to a helper function before thinking about other commands? |
the part of getting entity might look same but some additional steps are there, I didn't try DRY here because I was't sure if this will even worth if there is just this two cases. So I thought to - let's make them working and then refactor them properly.
Because it is not banning the user (I know stupid answer but truth lol). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArnabXD You can merge this if you approve my changes, too.
Co-authored-by: Roj <[email protected]>
Co-authored-by: Roj <[email protected]>
Co-authored-by: Roj <[email protected]>
Co-authored-by: Roj <[email protected]>
Co-authored-by: Roj <[email protected]>
Co-authored-by: Roj <[email protected]>
No description provided.