Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a failing test for #65. #66

Merged
merged 2 commits into from
Jan 3, 2016
Merged

Conversation

jamestalmage
Copy link
Contributor

See #65.

I haven't figured out the exact cause of the problem, but a fix for #65 should make this fixture pass.

I've deployed to @sindresorhus's repo, so anyone should be able to just checkout add-ignores-test-fixture if they want to take a crack at solving the problem.

@jamestalmage
Copy link
Contributor Author

5010bd7 is probably worthwhile on it's own.

sindresorhus added a commit that referenced this pull request Jan 3, 2016
@sindresorhus sindresorhus merged commit 3462ab6 into master Jan 3, 2016
@sindresorhus sindresorhus deleted the add-ignores-test-fixture branch January 3, 2016 12:02
@sindresorhus
Copy link
Member

👍

"version": "0.0.1",
"xo": {
"ignore": [
"{test/,}fixture{s,}/**"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamestalmage Looking at this again, should it be prefixed with !?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants