Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the code to use msgp. Add benchmarks. #223

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

schmidtw
Copy link
Member

@schmidtw schmidtw commented Feb 3, 2025

No description provided.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 148 lines in your changes missing coverage. Please review.

Project coverage is 85.02%. Comparing base (5faa7fb) to head (ddbcb26).
Report is 5 commits behind head on dev_v4.

Files with missing lines Patch % Lines
messages_gen.go 66.83% 101 Missing and 29 partials ⚠️
format.go 64.00% 16 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           dev_v4     #223      +/-   ##
==========================================
- Coverage   91.28%   85.02%   -6.26%     
==========================================
  Files          13       14       +1     
  Lines        1262     1683     +421     
==========================================
+ Hits         1152     1431     +279     
- Misses         93      205     +112     
- Partials       17       47      +30     
Flag Coverage Δ
unittests 85.02% <66.66%> (-6.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schmidtw schmidtw merged commit e4cd238 into dev_v4 Feb 3, 2025
13 of 15 checks passed
@schmidtw schmidtw deleted the switch-to-msgp branch February 3, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant