Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imgui versions v1.91.7 and v1.91.8 #6389

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

AidanSun05
Copy link
Contributor

No description provided.

@qudix
Copy link
Contributor

qudix commented Feb 19, 2025

Just add v1.91.8, there's no need to add the intermediary versions as I don't think CI will test those, only the latest.

@AidanSun05
Copy link
Contributor Author

I think the CI should be testing everything, in the logs (like from build (ubuntu-latest, shared, release) for example) it contains these lines:

[...]
  => install imgui v1.91.8 .. ok
[...]
  => install imgui#1 v1.91.7 .. ok
[...]
  => install imgui#2 v1.91.8-docking .. ok
[...]
  => install imgui#3 v1.91.7-docking .. ok

@star-hengxing
Copy link
Contributor

Just add v1.91.8, there's no need to add the intermediary versions as I don't think CI will test those, only the latest.

xmake-repo/scripts/test.lua

Lines 267 to 286 in cf1cdfe

for _, line in ipairs(diff:split("\n")) do
if line:startswith("+++ b/") then
local file = line:sub(7)
if file:startswith("packages") then
assert(file == file:lower(), "%s must be lower case!", file)
local package = file:match("packages/%w/(%S-)/")
table.insert(packages, package)
end
elseif line:startswith("+") and line:find("add_versions") then
local version = line:match("add_versions%(\"(.-)\"")
if version:find(":", 1, true) then
version = version:split(":")[2]
end
if #packages > 0 and version then
local lastpackage = packages[#packages]
local splitinfo = lastpackage:split("%s+")
table.insert(packages, splitinfo[1] .. " " .. version)
end
end
end

The test script will find all add_versions strings in the git diff.

@star-hengxing star-hengxing merged commit 9e71a99 into xmake-io:dev Feb 19, 2025
71 checks passed
@AidanSun05 AidanSun05 deleted the update-imgui branch February 19, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants