update open3d #6284
Draft
update open3d #6284
+45
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
Feb 5, 2025
packages/l/libxkbcommon/xmake.lua
Outdated
| print(os.files(package:installdir("**"))) | ||
|
|
||
| package:addenv("PATH", "bin") | ||
| package:addenv("PKG_CONFIG_PATH", path.join(package:installdir("lib"), "pkgconfig")) |
waruqi
reviewed
Feb 5, 2025
| import("package.tools.meson").install(package, configs) | ||
|
|
||
| package:addenv("PATH", "bin") | ||
| package:addenv("PKG_CONFIG_PATH", path.join("lib", "pkgconfig")) |
There was a problem hiding this comment.
其实这里不应该设置 PKG_CONFIG_PATH
目前 PKG_CONFIG_PATH 都是自动设置的，但是是在 调用 cmake/meson.install 安装包的时候，才会去从 依赖包中，提取 lib 路径设置 PKG_CONFIG_PATH 到 cmake/meson
所以 package:check_importfiles 中有可能检测不到库。应该改进 package:check_importfiles，也按类似的方式引入 PKG_CONFIG_PATH 才对。
这里直接对外导出 PKG_CONFIG_PATH 会污染 用户测 add_packages 后的所有脚本环境，对用户端 target 这个是没必要
There was a problem hiding this comment.
你可以先提个 issues 过来，等改进完 package:check_importfiles 再使用它
There was a problem hiding this comment.
不对，check_importfiles 已经加上 PKG_CONFIG_PATH 了，按理应该能 work ，为啥你这还要额外设置 PKG_CONFIG_PATH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.