Update libcurl #5892
Update libcurl #5892
Conversation
|
Reasons for the error on apple platform: curl/curl#14269 |
|
we can add curl/curl@5f6b924 as a patch for versions where it fails |
Thanks, I'm doing this. |
|
I think it's ready to be merged now. |
| if package:is_plat("linux", "android", "cross") then | ||
| package:config_set("openssl", true) | ||
| end |
There was a problem hiding this comment.
Removing those lines broke existing xmake projects doing add_requires("libcurl")
There was a problem hiding this comment.
It works fine on my device (linux, x86_64), can you provide more information?
There was a problem hiding this comment.
add_requires("libcurl") on Linux no longer links with libcurl and no longer has HTTPS support, resulting in unsupported protocol errors.
before your change, openssl support was enabled by default
There was a problem hiding this comment.
This does break the default HTTPS support, but this is expected because
- HTTPS support should not be forced, curl builds do not enforce ssl
- There are other options now (openssl3)
Downstreams should choose whether to enable encryption, and which one to enable.
There was a problem hiding this comment.
If one must be turned on one ssl backend by default, it is difficult to choose which one to turn on. I think it is best to let the user choose.
There was a problem hiding this comment.
I understand it's expected, but it's problematic to update a package and break the existing behavior, especially here where all xmake projects using libcurl will get a failure on the broadly used https protocol.
openssl should still be the default when no option is set, I think we can detect the case where openssl and openssl3 are not set (nil) and enable openssl as before for retrocompatibility.
@waruqi is this possible?
There was a problem hiding this comment.
I think the ability to build libcurl without SSL support needs to be preserved, is there a way for xmake to tell if a certain config is set "by default"? Otherwise I think it's a good idea to automatically enable openssl.
There was a problem hiding this comment.
I think so but I need confirmation from xmake author, afaik configs can have three values : true, false or nil (not set).
what I'm suggesting is basically:
if package:config("openssl") == nil and package:config("openssl3") == nil then
package:config_set("openssl", true)
endthis will support add_requires("libcurl", { configs = { openssl = false } }) as well
There was a problem hiding this comment.
If openssl is not explicitly set and no default value is configured in add_configs, it defaults to nil
following this package update: xmake-io/xmake-repo#5892 which disabled openssl by default
* libcurl: Restore openssl by default on Linux/Android See #5892 * Update xmake.lua
No description provided.