Rename FLAC__get_decoder_client_data to FLAC__stream_decoder_get_client_data #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... FLAC__stream_decoder_get_client_data. Also the function definition was moved to its 'siblings'. This way, the function fits better in the API with respect to naming.
|
I agree and have no objections. |
|
This is ok for me too. |
|
@ChristopD The change was left out of 1.3.4 because a release with security fixes was long overdue, and this change is one which changes the ABI/API in a breaking way. As there are a few more API changes coming up, we chose to group them into a next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also the function definition was moved to its 'siblings'. This way, the function fits better in the API with respect to naming. This implements the change suggested here
@sezero and @ChristopD do you agree with this? It is yet another change to the name, but as the first change has been kept out of 1.3.4, I think this should be fixed while we still can.