FLAC encoder adds spurious WAVEFORMATEXTENSIBLE_CHANNEL_MASK comment to non-WFE files

[gdtrfb55]

I encountered this issue while encoding a set of WAVE files with mixed bit depths. In my case, it was a group of fifteen alphabetically-sorted WAVE files, all of which were 2-16-44100, except for a single 2-24-48000 file in the sixth position. I encoded the files using a simple flac *.wav command. Much to my surprise, every 2-16-44100 file processed after the 2-24-48000 file had a spurious channel mask comment in it. Curiously, despite the channel mask comments, when the files containing the spurious comments were extracted back to WAVE, the format codes for the extracted WAVE files were 0x0001, not 0xfffe. So, the issue, whatever it is, seems to be related only to the insertion of the channel mask comment.

As a test, I renamed the 2-24-48000 file so that it would be processed first by flac *.wav. As expected, this caused a channel mask comment to be generated for every subsequent file.

This did not occur when I encoded each file separately, i.e., flac 01.wav, flac 02.wav, etc.

My guess is that some flag relating to the insertion of the channel mask comment isn't getting cleared between loops of the code that processes command-line arguments.

If you need additional information, just ask.

Thanks!

[ktmf01]

With which version of FLAC did you try this?

[gdtrfb55]

Forgot to mention that, didn’t I? 1.3.4, and it’s the first time I encountered the problem. Earlier versions didn’t exhibit this anomalous behavior.

…

On Thu, Jun 23, 2022 at 12:44 AM Martijn van Beurden < ***@***.***> wrote: With which version of FLAC did you try this? — Reply to this email directly, view it on GitHub <#376 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBP2KYAGUO4CTHLTY4LFPLVQP2T5ANCNFSM5ZNTLDLA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[gdtrfb55]

More accurately, 1.3.3 didn’t exhibit the problem. Versions before that didn’t generate channel mask comments.

…

On Thu, Jun 23, 2022 at 12:44 AM Martijn van Beurden < ***@***.***> wrote: With which version of FLAC did you try this? — Reply to this email directly, view it on GitHub <#376 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBP2KYAGUO4CTHLTY4LFPLVQP2T5ANCNFSM5ZNTLDLA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[ktmf01]

Are you sure about that? I just tried to bisect this and it seems this issue was already present in FLAC 1.2.1 (i.e. for 15 years already) Also, according to the changelog, mask comments were already written by FLAC 1.1.3

[ktmf01]

@gdtrfb55 If you are familiar with building FLAC from source, maybe you want to give the solution in #377 a try? Otherwise, I will consider it fixed with that PR, I was able to reproduce the problem and at my end #377 fixes it.

[gdtrfb55]

No worries. Patched clean against 1.3.4 release, and worked as expected with respect to file sets containing mixed bit depths. I believe this issue is closed. Thanks, Martijn, for your prompt reply and fix!

…

On Thu, Jun 23, 2022 at 3:44 PM Jack Browning ***@***.***> wrote: The fix should patch clean against the 1.3.4 release code, correct? On Thu, Jun 23, 2022 at 5:13 AM Martijn van Beurden < ***@***.***> wrote: > @gdtrfb55 <https://github.com/gdtrfb55> If you are familiar with > building FLAC from source, maybe you want to give the solution in #377 > <#377> a try? Otherwise, I will > consider it fixed with that PR, I was able to reproduce the problem and and > my end #377 <#377> fixes it. > > — > Reply to this email directly, view it on GitHub > <#376 (comment)>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACBP2K5ZTGHNARVNLJJWSFDVQQ2D5ANCNFSM5ZNTLDLA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

[gdtrfb55]

The fix should patch clean against the 1.3.4 release code, correct?

…

On Thu, Jun 23, 2022 at 5:13 AM Martijn van Beurden < ***@***.***> wrote: @gdtrfb55 <https://github.com/gdtrfb55> If you are familiar with building FLAC from source, maybe you want to give the solution in #377 <#377> a try? Otherwise, I will consider it fixed with that PR, I was able to reproduce the problem and and my end #377 <#377> fixes it. — Reply to this email directly, view it on GitHub <#376 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBP2K5ZTGHNARVNLJJWSFDVQQ2D5ANCNFSM5ZNTLDLA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ktmf01]

You said yourself that it did, I haven't checked. Why do you ask?